From f85bbb326e098123ebcd6dcf63ac0505ff6105a5 Mon Sep 17 00:00:00 2001
From: Carl Philipp Klemm <carl@uvos.xyz>
Date: Wed, 15 Apr 2026 12:15:07 +0200
Subject: [PATCH] Remove acestep binary path machinery

---
 src/AdvancedSettingsDialog.cpp | 19 ------------------
 src/AdvancedSettingsDialog.h   |  3 ---
 src/AdvancedSettingsDialog.ui  | 35 +++++++---------------------------
 src/MainWindow.cpp             |  4 ----
 src/MainWindow.h               |  1 -
 5 files changed, 7 insertions(+), 55 deletions(-)

diff --git a/src/AdvancedSettingsDialog.cpp b/src/AdvancedSettingsDialog.cpp
index fa6b233..96ef3c4 100644
--- a/src/AdvancedSettingsDialog.cpp
+++ b/src/AdvancedSettingsDialog.cpp
@@ -25,11 +25,6 @@ QString AdvancedSettingsDialog::getJsonTemplate() const
 	return ui->jsonTemplateEdit->toPlainText();
 }
 
-QString AdvancedSettingsDialog::getAceStepPath() const
-{
-	return ui->aceStepPathEdit->text();
-}
-
 QString AdvancedSettingsDialog::getQwen3ModelPath() const
 {
 	return ui->qwen3ModelEdit->text();
@@ -65,11 +60,6 @@ void AdvancedSettingsDialog::setJsonTemplate(const QString &templateStr)
 	ui->jsonTemplateEdit->setPlainText(templateStr);
 }
 
-void AdvancedSettingsDialog::setAceStepPath(const QString &path)
-{
-	ui->aceStepPathEdit->setText(path);
-}
-
 void AdvancedSettingsDialog::setQwen3ModelPath(const QString &path)
 {
 	ui->qwen3ModelEdit->setText(path);
@@ -100,15 +90,6 @@ void AdvancedSettingsDialog::setFlashAttention(bool enabled)
 	ui->flashAttentionCheckBox->setChecked(enabled);
 }
 
-void AdvancedSettingsDialog::on_aceStepBrowseButton_clicked()
-{
-	QString dir = QFileDialog::getExistingDirectory(this, "Select AceStep Build Directory", ui->aceStepPathEdit->text());
-	if (!dir.isEmpty())
-	{
-		ui->aceStepPathEdit->setText(dir);
-	}
-}
-
 void AdvancedSettingsDialog::on_qwen3BrowseButton_clicked()
 {
 	QString file = QFileDialog::getOpenFileName(this, "Select Qwen3 Model", ui->qwen3ModelEdit->text(),
diff --git a/src/AdvancedSettingsDialog.h b/src/AdvancedSettingsDialog.h
index a648539..2e00f3f 100644
--- a/src/AdvancedSettingsDialog.h
+++ b/src/AdvancedSettingsDialog.h
@@ -24,7 +24,6 @@ public:
 
 	// Getters for settings
 	QString getJsonTemplate() const;
-	QString getAceStepPath() const;
 	QString getQwen3ModelPath() const;
 	QString getTextEncoderModelPath() const;
 	QString getDiTModelPath() const;
@@ -34,7 +33,6 @@ public:
 
 	// Setters for settings
 	void setJsonTemplate(const QString &templateStr);
-	void setAceStepPath(const QString &path);
 	void setQwen3ModelPath(const QString &path);
 	void setTextEncoderModelPath(const QString &path);
 	void setDiTModelPath(const QString &path);
@@ -43,7 +41,6 @@ public:
 	void setFlashAttention(bool enabled);
 
 private slots:
-	void on_aceStepBrowseButton_clicked();
 	void on_qwen3BrowseButton_clicked();
 	void on_textEncoderBrowseButton_clicked();
 	void on_ditBrowseButton_clicked();
diff --git a/src/AdvancedSettingsDialog.ui b/src/AdvancedSettingsDialog.ui
index 9c9cd4a..6e95e90 100644
--- a/src/AdvancedSettingsDialog.ui
+++ b/src/AdvancedSettingsDialog.ui
@@ -105,34 +105,13 @@
         <enum>QFormLayout::FieldGrowthPolicy::AllNonFixedFieldsGrow</enum>
        </property>
        <item row="0" column="0">
-        <widget class="QLabel" name="aceStepLabel">
-         <property name="text">
-          <string>AceStep Path:</string>
-         </property>
-        </widget>
-       </item>
-       <item row="0" column="1">
-        <layout class="QHBoxLayout" name="aceStepLayout">
-         <item>
-          <widget class="QLineEdit" name="aceStepPathEdit"/>
-         </item>
-         <item>
-          <widget class="QPushButton" name="aceStepBrowseButton">
-           <property name="text">
-            <string>Browse...</string>
-           </property>
-          </widget>
-         </item>
-        </layout>
-       </item>
-       <item row="1" column="0">
         <widget class="QLabel" name="qwen3Label">
          <property name="text">
           <string>Qwen3 Model:</string>
          </property>
         </widget>
        </item>
-       <item row="1" column="1">
+       <item row="0" column="1">
         <layout class="QHBoxLayout" name="qwen3Layout">
          <item>
           <widget class="QLineEdit" name="qwen3ModelEdit"/>
@@ -146,14 +125,14 @@
          </item>
         </layout>
        </item>
-       <item row="2" column="0">
+       <item row="1" column="0">
         <widget class="QLabel" name="textEncoderLabel">
          <property name="text">
           <string>Text Encoder Model:</string>
          </property>
         </widget>
        </item>
-       <item row="2" column="1">
+       <item row="1" column="1">
         <layout class="QHBoxLayout" name="textEncoderLayout">
          <item>
           <widget class="QLineEdit" name="textEncoderEdit"/>
@@ -167,14 +146,14 @@
          </item>
         </layout>
        </item>
-       <item row="3" column="0">
+       <item row="2" column="0">
         <widget class="QLabel" name="ditLabel">
          <property name="text">
           <string>DiT Model:</string>
          </property>
         </widget>
        </item>
-       <item row="3" column="1">
+       <item row="2" column="1">
         <layout class="QHBoxLayout" name="ditLayout">
          <item>
           <widget class="QLineEdit" name="ditModelEdit"/>
@@ -188,14 +167,14 @@
          </item>
         </layout>
        </item>
-       <item row="4" column="0">
+       <item row="3" column="0">
         <widget class="QLabel" name="vaeLabel">
          <property name="text">
           <string>VAE Model:</string>
          </property>
         </widget>
        </item>
-       <item row="4" column="1">
+       <item row="3" column="1">
         <layout class="QHBoxLayout" name="vaeLayout">
          <item>
           <widget class="QLineEdit" name="vaeModelEdit"/>
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
index e8b0551..3f8c90e 100644
--- a/src/MainWindow.cpp
+++ b/src/MainWindow.cpp
@@ -155,7 +155,6 @@ void MainWindow::loadSettings()
 
 	// Load path settings with defaults based on application directory
 	QString appDir = QCoreApplication::applicationDirPath();
-	aceStepPath = settings.value("aceStepPath", appDir + "/acestep.cpp").toString();
 	qwen3ModelPath = settings.value("qwen3ModelPath",
 	                                appDir + "/acestep.cpp/models/acestep-5Hz-lm-4B-Q8_0.gguf").toString();
 	textEncoderModelPath = settings.value("textEncoderModelPath",
@@ -183,7 +182,6 @@ void MainWindow::saveSettings()
 	settings.setValue("shuffleMode", shuffleMode);
 
 	// Save path settings
-	settings.setValue("aceStepPath", aceStepPath);
 	settings.setValue("qwen3ModelPath", qwen3ModelPath);
 	settings.setValue("textEncoderModelPath", textEncoderModelPath);
 	settings.setValue("ditModelPath", ditModelPath);
@@ -390,7 +388,6 @@ void MainWindow::on_advancedSettingsButton_clicked()
 
 	// Set current values
 	dialog.setJsonTemplate(jsonTemplate);
-	dialog.setAceStepPath(aceStepPath);
 	dialog.setQwen3ModelPath(qwen3ModelPath);
 	dialog.setTextEncoderModelPath(textEncoderModelPath);
 	dialog.setDiTModelPath(ditModelPath);
@@ -411,7 +408,6 @@ void MainWindow::on_advancedSettingsButton_clicked()
 
 		// Update settings
 		jsonTemplate = dialog.getJsonTemplate();
-		aceStepPath = dialog.getAceStepPath();
 		qwen3ModelPath = dialog.getQwen3ModelPath();
 		textEncoderModelPath = dialog.getTextEncoderModelPath();
 		ditModelPath = dialog.getDiTModelPath();
diff --git a/src/MainWindow.h b/src/MainWindow.h
index 9d2a779..d87142c 100644
--- a/src/MainWindow.h
+++ b/src/MainWindow.h
@@ -50,7 +50,6 @@ class MainWindow : public QMainWindow
 	QString jsonTemplate;
 
 	// Path settings
-	QString aceStepPath;
 	QString qwen3ModelPath;
 	QString textEncoderModelPath;
 	QString ditModelPath;