From 03c2be79779235f4550a3477e17f20cca4409132 Mon Sep 17 00:00:00 2001
From: uvos <devnull@uvos.xyz>
Date: Fri, 15 Apr 2022 13:43:32 +0200
Subject: [PATCH] fix some compiler warnings

---
 src/actors/factoractor.cpp    | 5 +++--
 src/alarmactions.cpp          | 2 +-
 src/apgetconnected.cpp        | 4 ++++
 src/items/poweritem.cpp       | 2 +-
 src/sensors/speakersensor.cpp | 2 +-
 src/ui/sensorlistwidget.cpp   | 9 ---------
 6 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/actors/factoractor.cpp b/src/actors/factoractor.cpp
index 363b838..df4447f 100644
--- a/src/actors/factoractor.cpp
+++ b/src/actors/factoractor.cpp
@@ -26,8 +26,9 @@ void MultiFactorActor::setValue(uint8_t value)
 		{
 			performAction();
 		}
-		bool exausted = true;
-		for(size_t i = 0; i < getActors().size(); ++i) if(!getActors()[i]->isExausted()) exausted = false;
+		exausted = true;
+		for(size_t i = 0; i < getActors().size(); ++i) if(!getActors()[i]->isExausted())
+			exausted = false;
 	}
 }
 
diff --git a/src/alarmactions.cpp b/src/alarmactions.cpp
index 0a9a286..20853ce 100644
--- a/src/alarmactions.cpp
+++ b/src/alarmactions.cpp
@@ -10,6 +10,6 @@ AlarmActions::AlarmActions(QApplication* a, Microcontroller* micro, QObject *par
 void AlarmActions::syncoff()
 {
 	qDebug()<<"syncoff";
-	QProcess::execute ( "syncoff" );
+	QProcess::execute ("syncoff", QStringList());
 	a_->exit(0);
 }
diff --git a/src/apgetconnected.cpp b/src/apgetconnected.cpp
index b998dc8..2529950 100644
--- a/src/apgetconnected.cpp
+++ b/src/apgetconnected.cpp
@@ -53,6 +53,8 @@ static int nl80211Init(struct nl_sock* nl_sock, int* nl80211_id)
 
 static int errorHandler(struct sockaddr_nl *nla, struct nlmsgerr *err, void *arg)
 {
+	(void)nla;
+	(void)err;
 	printf("netlink error\n");
 	*reinterpret_cast<int*>(arg) = 0;
 	return NL_STOP;
@@ -60,12 +62,14 @@ static int errorHandler(struct sockaddr_nl *nla, struct nlmsgerr *err, void *arg
 
 static int finishHandler(struct nl_msg *msg, void *arg)
 {
+	(void)msg;
 	*reinterpret_cast<int*>(arg) = 0;
 	return NL_SKIP;
 }
 
 static int ackHandler(struct nl_msg *msg, void *arg)
 {
+	(void)msg;
 	*reinterpret_cast<int*>(arg) = 0;
 	return NL_STOP;
 }
diff --git a/src/items/poweritem.cpp b/src/items/poweritem.cpp
index ab0ce25..998e6d2 100644
--- a/src/items/poweritem.cpp
+++ b/src/items/poweritem.cpp
@@ -24,7 +24,7 @@ void PowerItem::setValue(uint8_t value)
 void PowerItem::timeout()
 {
 	qDebug()<<"shutdown timeout";
-	QProcess::startDetached("syncoff");
+	QProcess::startDetached("syncoff", QStringList());
 }
 
 void PowerItem::store(QJsonObject& json)
diff --git a/src/sensors/speakersensor.cpp b/src/sensors/speakersensor.cpp
index 5b36d66..e2a4171 100644
--- a/src/sensors/speakersensor.cpp
+++ b/src/sensors/speakersensor.cpp
@@ -15,7 +15,7 @@ SpeakerSensorSource::~SpeakerSensorSource()
 void SpeakerSensorSource::run()
 {
 	abort();
-	arecord.start( "arecord --disable-softvol -r 8000 -D front -" );
+	arecord.start( "arecord", {"--disable-softvol", "-r", "8000", "-D", "front", "-"});
 
 	connect(&timer, SIGNAL(timeout()), this, SLOT(doTick()));
 	timer.setInterval(500);
diff --git a/src/ui/sensorlistwidget.cpp b/src/ui/sensorlistwidget.cpp
index 1b1a68d..2c5c490 100644
--- a/src/ui/sensorlistwidget.cpp
+++ b/src/ui/sensorlistwidget.cpp
@@ -28,15 +28,6 @@ void SensorListWidget::sensorsChanged(std::vector<Sensor> sensors)
 	clear();
 	setHorizontalHeaderItem(0, new QTableWidgetItem("Sensor"));
 	setHorizontalHeaderItem(1, new QTableWidgetItem("Value"));
-	size_t nonHiddenCount = sensors.size();
-	if(!showHidden_)
-	{
-		nonHiddenCount = 0;
-		for(size_t i = 0; i < sensors.size(); ++i)
-		{
-			if(!sensors[i].hidden) nonHiddenCount++;
-		}
-	}
 	size_t listLen = 0;
 	for(size_t i = 0; i < sensors.size(); ++i) if(showHidden_ || !sensors[i].hidden) ++listLen;
 	setRowCount(static_cast<int>(listLen));