Fix memory leak in XInstance::getTopLevelWindows

2020-06-16 09:54:22 +02:00
parent bdcd27eb95
commit 8c69a02e5d
3 changed files with 7 additions and 3 deletions
--- a/xinstance.cpp
+++ b/xinstance.cpp
@ -107,13 +107,13 @@ std::vector<Window> XInstance::getTopLevelWindows()
    Window* windows = nullptr;
    unsigned int nwindows;
    XQueryTree(display, RootWindow(display, screen), &root_return, &parent_return, &windows, &nwindows);
-    
    std::vector<Window> out;
    out.reserve(nwindows);
-    for(unsigned int i; i < nwindows; ++i)
+    for(unsigned int i = 0; i < nwindows; ++i)
    {
        out.push_back(windows[i]);
    }
+    if(windows != nullptr) XFree(windows);
    return out;
 }