v1.3.0

Co-Authored-By: Quentin Torroba <quentin.torroba@mistral.ai>
Co-Authored-By: Michel Thomazo <michel.thomazo@mistral.ai>
Co-Authored-By: Clément Drouin <clement.drouin@mistral.ai>
Co-Authored-by: Thiago Padilha <thiago@coplane.com>

tests/skills/test_manager.py

@@ -0,0 +1,275 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+import pytest
+
+from tests.skills.conftest import create_skill
+from vibe.core.config import SessionLoggingConfig, VibeConfig
+from vibe.core.skills.manager import SkillManager
+
+
+@pytest.fixture
+def config() -> VibeConfig:
+    return VibeConfig(
+        session_logging=SessionLoggingConfig(enabled=False),
+        system_prompt_id="tests",
+        include_project_context=False,
+    )
+
+
+@pytest.fixture
+def skill_manager(config: VibeConfig) -> SkillManager:
+    return SkillManager(config)
+
+
+class TestSkillManagerDiscovery:
+    def test_discovers_no_skills_when_directory_empty(
+        self, skill_manager: SkillManager
+    ) -> None:
+        assert skill_manager.available_skills == {}
+
+    def test_discovers_skill_from_skill_paths(self, skills_dir: Path) -> None:
+        create_skill(skills_dir, "test-skill", "A test skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        assert "test-skill" in manager.available_skills
+        assert manager.available_skills["test-skill"].description == "A test skill"
+
+    def test_discovers_multiple_skills(self, skills_dir: Path) -> None:
+        create_skill(skills_dir, "skill-one", "First skill")
+        create_skill(skills_dir, "skill-two", "Second skill")
+        create_skill(skills_dir, "skill-three", "Third skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        assert len(manager.available_skills) == 3
+        assert "skill-one" in manager.available_skills
+        assert "skill-two" in manager.available_skills
+        assert "skill-three" in manager.available_skills
+
+    def test_ignores_directories_without_skill_md(self, skills_dir: Path) -> None:
+        # Create a directory that's not a skill
+        not_a_skill = skills_dir / "not-a-skill"
+        not_a_skill.mkdir()
+        (not_a_skill / "README.md").write_text("Not a skill")
+
+        # Create a valid skill
+        create_skill(skills_dir, "valid-skill", "A valid skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 1
+        assert "valid-skill" in skills
+        assert "not-a-skill" not in skills
+
+    def test_ignores_files_in_skills_directory(self, skills_dir: Path) -> None:
+        # Create a file in the skills directory (not a directory)
+        (skills_dir / "not-a-directory.md").write_text("Just a file")
+
+        # Create a valid skill
+        create_skill(skills_dir, "valid-skill", "A valid skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 1
+        assert "valid-skill" in skills
+
+
+class TestSkillManagerParsing:
+    def test_parses_all_skill_fields(self, skills_dir: Path) -> None:
+        create_skill(
+            skills_dir,
+            "full-skill",
+            "A skill with all fields",
+            license="MIT",
+            compatibility="Requires git",
+            metadata={"author": "Test Author", "version": "1.0"},
+            allowed_tools="bash read_file",
+        )
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skill = manager.get_skill("full-skill")
+        assert skill is not None
+        assert skill.name == "full-skill"
+        assert skill.description == "A skill with all fields"
+        assert skill.license == "MIT"
+        assert skill.compatibility == "Requires git"
+        assert skill.metadata == {"author": "Test Author", "version": "1.0"}
+        assert skill.allowed_tools == ["bash", "read_file"]
+
+    def test_sets_correct_skill_path(self, skills_dir: Path) -> None:
+        create_skill(skills_dir, "test-skill", "A test skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skill = manager.get_skill("test-skill")
+        assert skill is not None
+        assert skill.skill_path == skills_dir / "test-skill" / "SKILL.md"
+        assert skill.skill_dir == skills_dir / "test-skill"
+
+    def test_skips_skill_with_invalid_frontmatter(self, skills_dir: Path) -> None:
+        # Create an invalid skill
+        invalid_skill_dir = skills_dir / "invalid-skill"
+        invalid_skill_dir.mkdir()
+        (invalid_skill_dir / "SKILL.md").write_text("No frontmatter here")
+
+        # Create a valid skill
+        create_skill(skills_dir, "valid-skill", "A valid skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 1
+        assert "valid-skill" in skills
+        assert "invalid-skill" not in skills
+
+    def test_skips_skill_with_missing_required_fields(self, skills_dir: Path) -> None:
+        # Create skill missing description
+        missing_desc_dir = skills_dir / "missing-desc"
+        missing_desc_dir.mkdir()
+        (missing_desc_dir / "SKILL.md").write_text("---\nname: missing-desc\n---\n")
+
+        # Create a valid skill
+        create_skill(skills_dir, "valid-skill", "A valid skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 1
+        assert "valid-skill" in skills
+
+
+class TestSkillManagerSearchPaths:
+    def test_discovers_from_multiple_skill_paths(self, tmp_path: Path) -> None:
+        # Create two separate skill directories
+        skills_dir_1 = tmp_path / "skills1"
+        skills_dir_1.mkdir()
+        create_skill(skills_dir_1, "skill-from-dir1", "Skill from directory 1")
+
+        skills_dir_2 = tmp_path / "skills2"
+        skills_dir_2.mkdir()
+        create_skill(skills_dir_2, "skill-from-dir2", "Skill from directory 2")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir_1, skills_dir_2],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 2
+        assert "skill-from-dir1" in skills
+        assert "skill-from-dir2" in skills
+
+    def test_first_discovered_wins_for_duplicates(self, tmp_path: Path) -> None:
+        # Create two directories with the same skill name
+        skills_dir_1 = tmp_path / "skills1"
+        skills_dir_1.mkdir()
+        create_skill(skills_dir_1, "duplicate-skill", "First version")
+
+        skills_dir_2 = tmp_path / "skills2"
+        skills_dir_2.mkdir()
+        create_skill(skills_dir_2, "duplicate-skill", "Second version")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir_1, skills_dir_2],
+        )
+        manager = SkillManager(config)
+
+        skills = manager.available_skills
+        assert len(skills) == 1
+        assert skills["duplicate-skill"].description == "First version"
+
+    def test_ignores_nonexistent_skill_paths(self, tmp_path: Path) -> None:
+        skills_dir = tmp_path / "skills"
+        skills_dir.mkdir()
+        create_skill(skills_dir, "valid-skill", "A valid skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir, tmp_path / "nonexistent"],
+        )
+        manager = SkillManager(config)
+
+        assert len(manager.available_skills) == 1
+        assert "valid-skill" in manager.available_skills
+
+
+class TestSkillManagerGetSkill:
+    def test_returns_skill_by_name(self, skills_dir: Path) -> None:
+        create_skill(skills_dir, "test-skill", "A test skill")
+
+        config = VibeConfig(
+            session_logging=SessionLoggingConfig(enabled=False),
+            system_prompt_id="tests",
+            include_project_context=False,
+            skill_paths=[skills_dir],
+        )
+        manager = SkillManager(config)
+
+        skill = manager.get_skill("test-skill")
+        assert skill is not None
+        assert skill.name == "test-skill"
+
+    def test_returns_none_for_unknown_skill(self, skill_manager: SkillManager) -> None:
+        assert skill_manager.get_skill("nonexistent-skill") is None