v2.3.0 (#429)

Co-authored-by: Carlo <carloantonio.patti@mistral.ai>
Co-authored-by: Mathias Gesbert <mathias.gesbert@mistral.ai>
Co-authored-by: Clement Sirieix <clem.sirieix@gmail.com>
Co-authored-by: Michel Thomazo <michel.thomazo@mistral.ai>
Co-authored-by: Clément Drouin <clement.drouin@mistral.ai>
Co-authored-by: Vincent Guilloux <vincent.guilloux@mistral.ai>
Co-authored-by: Thomas Kenbeek <thomas.kenbeek@mistral.ai>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/tools/test_task.py

@@ -8,7 +8,7 @@ from tests.conftest import build_test_vibe_config
 from tests.mock.utils import collect_result
 from vibe.core.agents.manager import AgentManager
 from vibe.core.agents.models import BUILTIN_AGENTS, AgentType
-from vibe.core.tools.base import BaseToolState, InvokeContext, ToolError
+from vibe.core.tools.base import BaseToolState, InvokeContext, ToolError, ToolPermission
 from vibe.core.tools.builtins.task import Task, TaskArgs, TaskResult, TaskToolConfig
 from vibe.core.types import AssistantEvent, LLMMessage, Role
 
@@ -76,6 +76,50 @@ class TestTaskToolValidation:
         assert agent.agent_type == AgentType.SUBAGENT
 
 
+class TestTaskToolResolvePermission:
+    def test_explore_allowed_by_default(self, task_tool: Task) -> None:
+        args = TaskArgs(task="do something", agent="explore")
+        result = task_tool.resolve_permission(args)
+        assert result == ToolPermission.ALWAYS
+
+    def test_unknown_agent_returns_none(self, task_tool: Task) -> None:
+        args = TaskArgs(task="do something", agent="custom_agent")
+        result = task_tool.resolve_permission(args)
+        assert result is None
+
+    def test_denylist_takes_precedence(self) -> None:
+        config = TaskToolConfig(allowlist=["explore"], denylist=["explore"])
+        tool = Task(config=config, state=BaseToolState())
+        args = TaskArgs(task="do something", agent="explore")
+        result = tool.resolve_permission(args)
+        assert result == ToolPermission.NEVER
+
+    def test_glob_pattern_in_allowlist(self) -> None:
+        config = TaskToolConfig(allowlist=["exp*"])
+        tool = Task(config=config, state=BaseToolState())
+        args = TaskArgs(task="do something", agent="explore")
+        result = tool.resolve_permission(args)
+        assert result == ToolPermission.ALWAYS
+
+    def test_glob_pattern_in_denylist(self) -> None:
+        config = TaskToolConfig(denylist=["danger*"])
+        tool = Task(config=config, state=BaseToolState())
+        args = TaskArgs(task="do something", agent="dangerous_agent")
+        result = tool.resolve_permission(args)
+        assert result == ToolPermission.NEVER
+
+    def test_empty_lists_returns_none(self) -> None:
+        config = TaskToolConfig(allowlist=[], denylist=[])
+        tool = Task(config=config, state=BaseToolState())
+        args = TaskArgs(task="do something", agent="explore")
+        result = tool.resolve_permission(args)
+        assert result is None
+
+    def test_default_config_has_explore_in_allowlist(self) -> None:
+        config = TaskToolConfig()
+        assert "explore" in config.allowlist
+
+
 class TestTaskToolExecution:
     @pytest.fixture
     def ctx(self) -> InvokeContext: