v2.9.0 (#641)

Co-authored-by: Antoine <33425718+anth2o@users.noreply.github.com>
Co-authored-by: Bastien <bastien.baret@gmail.com>
Co-authored-by: Clément Sirieix <clement.sirieix@mistral.ai>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Mathias Gesbert <mathias.gesbert@mistral.ai>
Co-authored-by: Maxime Dolores <maxime.dolores@ext.mistral.ai>
Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com>
Co-authored-by: Nelson PROIA <144663685+Nelson-PROIA@users.noreply.github.com>
Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai>
Co-authored-by: Quentin <quentin.torroba@mistral.ai>
Co-authored-by: Robin Gullo <robin.gullo@mistral.ai>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/acp/test_close_session.py

@@ -0,0 +1,101 @@
+from __future__ import annotations
+
+import asyncio
+from typing import Any, cast
+from unittest.mock import AsyncMock
+
+from acp import RequestError
+from acp.schema import TextContentBlock
+import pytest
+
+from vibe.acp.acp_agent_loop import VibeAcpAgentLoop
+
+
+class TestCloseSession:
+    @pytest.mark.asyncio
+    async def test_close_session_removes_session_and_closes_resources(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(cwd=".", mcp_servers=[])
+        session = acp_agent_loop.sessions[session_response.session_id]
+
+        backend_close = AsyncMock()
+        telemetry_close = AsyncMock()
+        cast(Any, session.agent_loop.backend).close = backend_close
+        session.agent_loop.telemetry_client.aclose = telemetry_close
+
+        response = await acp_agent_loop.close_session(session_response.session_id)
+
+        assert response is not None
+        assert session_response.session_id not in acp_agent_loop.sessions
+        backend_close.assert_awaited_once()
+        telemetry_close.assert_awaited_once()
+
+    @pytest.mark.asyncio
+    async def test_close_session_cancels_active_prompt(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(cwd=".", mcp_servers=[])
+        session = acp_agent_loop.sessions[session_response.session_id]
+
+        async def wait_forever() -> None:
+            await asyncio.Event().wait()
+
+        task = session.set_prompt_task(wait_forever())
+        session.agent_loop.telemetry_client.aclose = AsyncMock()
+
+        await acp_agent_loop.close_session(session_response.session_id)
+
+        assert task.cancelled()
+
+    @pytest.mark.asyncio
+    async def test_close_session_cancels_background_tasks(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(cwd=".", mcp_servers=[])
+        session = acp_agent_loop.sessions[session_response.session_id]
+
+        background_event = asyncio.Event()
+
+        async def background_work() -> None:
+            await background_event.wait()
+
+        bg_task = session.spawn(background_work())
+        assert bg_task is not None
+
+        session.agent_loop.telemetry_client.aclose = AsyncMock()
+
+        await acp_agent_loop.close_session(session_response.session_id)
+
+        assert bg_task.cancelled()
+
+    @pytest.mark.asyncio
+    async def test_close_session_rejects_new_background_tasks(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(cwd=".", mcp_servers=[])
+        session = acp_agent_loop.sessions[session_response.session_id]
+        session.agent_loop.telemetry_client.aclose = AsyncMock()
+
+        await acp_agent_loop.close_session(session_response.session_id)
+
+        async def noop() -> None:
+            pass
+
+        assert session.spawn(noop()) is None
+
+    @pytest.mark.asyncio
+    async def test_closed_session_rejects_new_prompts(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(cwd=".", mcp_servers=[])
+        session = acp_agent_loop.sessions[session_response.session_id]
+        session.agent_loop.telemetry_client.aclose = AsyncMock()
+
+        await acp_agent_loop.close_session(session_response.session_id)
+
+        with pytest.raises(RequestError, match="Session not found"):
+            await acp_agent_loop.prompt(
+                prompt=[TextContentBlock(type="text", text="Hello")],
+                session_id=session_response.session_id,
+            )