v1.1.3

Co-Authored-By: Quentin Torroba <quentin.torroba@mistral.ai>
Co-Authored-By: Michel Thomazo <michel.thomazo@mistral.ai>
Co-Authored-By: Vincent Guilloux <vincent.guilloux@mistral.ai>

tests/update_notifier/test_ui_version_update_notification.py

@@ -1,16 +1,21 @@
 from __future__ import annotations
 
 import asyncio
+import time
 from typing import Protocol
 
 import pytest
 from textual.app import Notification
 
-from vibe.cli.textual_ui.app import VibeApp
-from vibe.cli.update_notifier.fake_version_update_gateway import (
+from tests.update_notifier.adapters.fake_update_cache_repository import (
+    FakeUpdateCacheRepository,
+)
+from tests.update_notifier.adapters.fake_version_update_gateway import (
     FakeVersionUpdateGateway,
 )
-from vibe.cli.update_notifier.version_update_gateway import (
+from vibe.cli.textual_ui.app import VibeApp
+from vibe.cli.update_notifier import (
+    UpdateCache,
     VersionUpdate,
     VersionUpdateGatewayCause,
     VersionUpdateGatewayError,
@@ -59,6 +64,7 @@ class VibeAppFactory(Protocol):
         self,
         *,
         notifier: FakeVersionUpdateGateway,
+        update_cache_repository: FakeUpdateCacheRepository | None = None,
         config: VibeConfig | None = None,
         auto_approve: bool = False,
         current_version: str = "0.1.0",
@@ -67,9 +73,13 @@ class VibeAppFactory(Protocol):
 
 @pytest.fixture
 def make_vibe_app(vibe_config_with_update_checks_enabled: VibeConfig) -> VibeAppFactory:
+    update_cache_repository = FakeUpdateCacheRepository()
+
     def _make_app(
         *,
         notifier: FakeVersionUpdateGateway,
+        update_cache_repository: FakeUpdateCacheRepository
+        | None = update_cache_repository,
         config: VibeConfig | None = None,
         auto_approve: bool = False,
         current_version: str = "0.1.0",
@@ -78,6 +88,7 @@ def make_vibe_app(vibe_config_with_update_checks_enabled: VibeConfig) -> VibeApp
             config=config or vibe_config_with_update_checks_enabled,
             auto_approve=auto_approve,
             version_update_notifier=notifier,
+            update_cache_repository=update_cache_repository,
             current_version=current_version,
         )
 
@@ -159,3 +170,52 @@ async def test_ui_does_not_invoke_gateway_nor_show_update_notification_when_upda
         await _assert_no_notifications(app, pilot, timeout=0.3)
 
     assert notifier.fetch_update_calls == 0
+
+
+@pytest.mark.asyncio
+async def test_ui_does_not_show_toast_when_update_is_known_in_recent_cache_already(
+    make_vibe_app: VibeAppFactory,
+) -> None:
+    timestamp_two_hours_ago = int(time.time()) - 2 * 60 * 60
+    notifier = FakeVersionUpdateGateway(update=VersionUpdate(latest_version="0.2.0"))
+    update_cache = UpdateCache(
+        latest_version="0.2.0", stored_at_timestamp=timestamp_two_hours_ago
+    )
+    update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
+    app = make_vibe_app(
+        notifier=notifier, update_cache_repository=update_cache_repository
+    )
+
+    async with app.run_test() as pilot:
+        await _assert_no_notifications(app, pilot, timeout=0.3)
+
+    assert notifier.fetch_update_calls == 0
+
+
+@pytest.mark.asyncio
+async def test_ui_does_show_toast_when_cache_entry_is_too_old(
+    make_vibe_app: VibeAppFactory,
+) -> None:
+    timestamp_two_days_ago = int(time.time()) - 2 * 24 * 60 * 60
+    notifier = FakeVersionUpdateGateway(update=VersionUpdate(latest_version="0.2.0"))
+    update_cache = UpdateCache(
+        latest_version="0.2.0", stored_at_timestamp=timestamp_two_days_ago
+    )
+    update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
+    app = make_vibe_app(
+        notifier=notifier, update_cache_repository=update_cache_repository
+    )
+
+    async with app.run_test() as pilot:
+        await pilot.pause(0.3)
+        notifications = list(app._notifications)
+
+    assert notifications
+    notification = notifications[-1]
+    assert notification.severity == "information"
+    assert notification.title == "Update available"
+    assert (
+        notification.message
+        == '0.1.0 => 0.2.0\nRun "uv tool upgrade mistral-vibe" to update'
+    )
+    assert notifier.fetch_update_calls == 1