v2.17.0 (#822)

Co-authored-by: Clément Sirieix <clement.sirieix@mistral.ai>
Co-authored-by: Guillaume LE GOFF <guillaume.lgf@gmail.com>
Co-authored-by: Hdandria <henri.dandria@mistral.ai>
Co-authored-by: Ivana Dunisijevic <ivana.dunisijevic@mistral.ai>
Co-authored-by: Jean Burellier <sheplu@users.noreply.github.com>
Co-authored-by: Mathias Gesbert <mathias.gesbert@mistral.ai>
Co-authored-by: Mert Unsal <mert.unsal@mistral.ai>
Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com>
Co-authored-by: Paul VEZIA <166131032+le-codeur-rapide@users.noreply.github.com>
Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai>
Co-authored-by: Val <102326092+vdeva@users.noreply.github.com>
Co-authored-by: Vincent G <10739306+VinceOPS@users.noreply.github.com>
Co-authored-by: renovate-mistral[bot] <253709520+renovate-mistral[bot]@users.noreply.github.com>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/agent_loop/test_agent_override_resolve_permission.py

@@ -0,0 +1,109 @@
+from __future__ import annotations
+
+from tests.conftest import build_test_agent_loop, build_test_vibe_config
+from vibe.core.agents.models import BuiltinAgentName
+from vibe.core.paths import PLANS_DIR
+from vibe.core.tools.base import ToolPermission
+
+
+class TestPlanAgentWriteFileResolvePermission:
+    """Plan agent sets write_file to NEVER with allowlist=[plans/*].
+    resolve_permission must use this, not the base config.
+    """
+
+    def test_write_file_to_non_plan_path_denied_in_plan_mode(self) -> None:
+        config = build_test_vibe_config()
+        agent = build_test_agent_loop(config=config, agent_name=BuiltinAgentName.PLAN)
+
+        tool = agent.tool_manager.get("write_file")
+        from vibe.core.tools.builtins.write_file import WriteFileArgs
+
+        args = WriteFileArgs(path="/some/random/file.py", content="hello")
+
+        ctx = tool.resolve_permission(args)
+
+        # With plan agent override: permission should be NEVER
+        # (unless the path matches the plans allowlist)
+        assert ctx is not None
+        assert ctx.permission == ToolPermission.NEVER
+
+    def test_write_file_to_plan_path_allowed_in_plan_mode(self) -> None:
+        config = build_test_vibe_config()
+        agent = build_test_agent_loop(config=config, agent_name=BuiltinAgentName.PLAN)
+
+        tool = agent.tool_manager.get("write_file")
+        from vibe.core.tools.builtins.write_file import WriteFileArgs
+
+        plan_path = str(PLANS_DIR.path / "my-plan.md")
+        args = WriteFileArgs(path=plan_path, content="# Plan")
+
+        ctx = tool.resolve_permission(args)
+
+        # Plan path is in the allowlist, so should be ALWAYS
+        assert ctx is not None
+        assert ctx.permission == ToolPermission.ALWAYS
+
+    def test_edit_to_non_plan_path_denied_in_plan_mode(self) -> None:
+        config = build_test_vibe_config()
+        agent = build_test_agent_loop(config=config, agent_name=BuiltinAgentName.PLAN)
+
+        tool = agent.tool_manager.get("edit")
+        from vibe.core.tools.builtins.edit import EditArgs
+
+        args = EditArgs(file_path="/some/file.py", old_string="a", new_string="b")
+
+        ctx = tool.resolve_permission(args)
+
+        assert ctx is not None
+        assert ctx.permission == ToolPermission.NEVER
+
+
+class TestAcceptEditsAgentResolvePermission:
+    """Accept-edits agent sets write_file/edit to ALWAYS.
+    resolve_permission must reflect this.
+    """
+
+    def test_write_file_always_in_accept_edits_mode(self) -> None:
+        config = build_test_vibe_config()
+        agent = build_test_agent_loop(
+            config=config, agent_name=BuiltinAgentName.ACCEPT_EDITS
+        )
+
+        tool = agent.tool_manager.get("write_file")
+        from vibe.core.tools.builtins.write_file import WriteFileArgs
+
+        # Use a workdir-relative path; outside-workdir always requires ASK
+        # regardless of agent permission.
+        args = WriteFileArgs(path="file.py", content="hello")
+
+        ctx = tool.resolve_permission(args)
+
+        # Inside workdir, no allowlist/denylist/sensitive match → None,
+        # so the caller falls through to config permission (ALWAYS).
+        assert ctx is None
+
+
+class TestAgentOverrideNotLeakedAcrossSwitches:
+    """Switching agents must change what resolve_permission returns."""
+
+    def test_switch_from_plan_to_default_restores_write_permission(self) -> None:
+        config = build_test_vibe_config()
+        agent = build_test_agent_loop(config=config, agent_name=BuiltinAgentName.PLAN)
+
+        tool = agent.tool_manager.get("write_file")
+        from vibe.core.tools.builtins.write_file import WriteFileArgs
+
+        args = WriteFileArgs(path="/some/file.py", content="hello")
+
+        # In plan mode: should be NEVER
+        ctx_plan = tool.resolve_permission(args)
+        assert ctx_plan is not None
+        assert ctx_plan.permission == ToolPermission.NEVER
+
+        # Switch to default
+        agent.agent_manager.switch_profile(BuiltinAgentName.DEFAULT)
+
+        # In default mode: should NOT be NEVER
+        ctx_default = tool.resolve_permission(args)
+        assert ctx_default is not None
+        assert ctx_default.permission != ToolPermission.NEVER