v2.17.0 (#822)
Co-authored-by: Clément Sirieix <clement.sirieix@mistral.ai> Co-authored-by: Guillaume LE GOFF <guillaume.lgf@gmail.com> Co-authored-by: Hdandria <henri.dandria@mistral.ai> Co-authored-by: Ivana Dunisijevic <ivana.dunisijevic@mistral.ai> Co-authored-by: Jean Burellier <sheplu@users.noreply.github.com> Co-authored-by: Mathias Gesbert <mathias.gesbert@mistral.ai> Co-authored-by: Mert Unsal <mert.unsal@mistral.ai> Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com> Co-authored-by: Paul VEZIA <166131032+le-codeur-rapide@users.noreply.github.com> Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai> Co-authored-by: Val <102326092+vdeva@users.noreply.github.com> Co-authored-by: Vincent G <10739306+VinceOPS@users.noreply.github.com> Co-authored-by: renovate-mistral[bot] <253709520+renovate-mistral[bot]@users.noreply.github.com> Co-authored-by: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
parent
564a14365e
commit
6bedf271ce
223 changed files with 10533 additions and 6947 deletions
|
|
@ -1,505 +0,0 @@
|
|||
from __future__ import annotations
|
||||
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
from mcp.types import (
|
||||
CreateMessageRequestParams,
|
||||
CreateMessageResult,
|
||||
SamplingMessage,
|
||||
TextContent,
|
||||
)
|
||||
import pytest
|
||||
|
||||
from tests.conftest import (
|
||||
build_test_agent_loop,
|
||||
build_test_vibe_config,
|
||||
make_test_models,
|
||||
)
|
||||
from tests.mock.utils import mock_llm_chunk
|
||||
from tests.stubs.fake_backend import FakeBackend
|
||||
from vibe.core.agents.models import BuiltinAgentName
|
||||
from vibe.core.config import ModelConfig, ProviderConfig, VibeConfig
|
||||
from vibe.core.telemetry.types import EntrypointMetadata
|
||||
from vibe.core.tools.base import BaseToolConfig, ToolPermission
|
||||
from vibe.core.types import (
|
||||
Backend,
|
||||
FunctionCall,
|
||||
LLMChunk,
|
||||
LLMMessage,
|
||||
LLMUsage,
|
||||
RefusalError,
|
||||
Role,
|
||||
StopInfo,
|
||||
ToolCall,
|
||||
)
|
||||
|
||||
|
||||
def _two_model_vibe_config(active_model: str) -> VibeConfig:
|
||||
"""VibeConfig with two models so we can switch active_model."""
|
||||
models = [
|
||||
ModelConfig(
|
||||
name="mistral-vibe-cli-latest", provider="mistral", alias="devstral-latest"
|
||||
),
|
||||
ModelConfig(
|
||||
name="devstral-small-latest", provider="mistral", alias="devstral-small"
|
||||
),
|
||||
]
|
||||
providers = [
|
||||
ProviderConfig(
|
||||
name="mistral",
|
||||
api_base="https://api.mistral.ai/v1",
|
||||
api_key_env_var="MISTRAL_API_KEY",
|
||||
backend=Backend.MISTRAL,
|
||||
)
|
||||
]
|
||||
return build_test_vibe_config(
|
||||
active_model=active_model, models=models, providers=providers
|
||||
)
|
||||
|
||||
|
||||
def _make_sampling_params() -> CreateMessageRequestParams:
|
||||
return CreateMessageRequestParams(
|
||||
messages=[
|
||||
SamplingMessage(role="user", content=TextContent(type="text", text="Hi"))
|
||||
],
|
||||
systemPrompt=None,
|
||||
temperature=None,
|
||||
maxTokens=100,
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_passes_x_affinity_header_when_asking_an_answer(vibe_config: VibeConfig):
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_extra_headers) > 0
|
||||
headers = backend.requests_extra_headers[0]
|
||||
assert headers is not None
|
||||
assert "x-affinity" in headers
|
||||
assert headers["x-affinity"] == agent.session_id
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_passes_x_affinity_header_when_asking_an_answer_streaming(
|
||||
vibe_config: VibeConfig,
|
||||
):
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
agent = build_test_agent_loop(
|
||||
config=vibe_config, backend=backend, enable_streaming=True
|
||||
)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_extra_headers) > 0
|
||||
headers = backend.requests_extra_headers[0]
|
||||
assert headers is not None
|
||||
assert "x-affinity" in headers
|
||||
assert headers["x-affinity"] == agent.session_id
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_updates_tokens_stats_based_on_backend_response(vibe_config: VibeConfig):
|
||||
chunk = mock_llm_chunk(content="Response", prompt_tokens=100, completion_tokens=50)
|
||||
backend = FakeBackend([chunk])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert agent.stats.context_tokens == 150
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_updates_tokens_stats_based_on_backend_response_streaming(
|
||||
vibe_config: VibeConfig,
|
||||
):
|
||||
final_chunk = mock_llm_chunk(
|
||||
content="Complete", prompt_tokens=200, completion_tokens=75
|
||||
)
|
||||
backend = FakeBackend([final_chunk])
|
||||
agent = build_test_agent_loop(
|
||||
config=vibe_config, backend=backend, enable_streaming=True
|
||||
)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert agent.stats.context_tokens == 275
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_passes_session_id_to_backend(vibe_config: VibeConfig):
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_metadata) > 0
|
||||
meta = backend.requests_metadata[0]
|
||||
assert meta is not None
|
||||
assert meta["session_id"] == agent.session_id
|
||||
assert "parent_session_id" not in meta
|
||||
assert "message_id" in meta
|
||||
assert meta["call_type"] == "main_call"
|
||||
assert meta["call_source"] == "vibe_code"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_passes_parent_session_id_to_backend_after_reset(vibe_config: VibeConfig):
|
||||
backend = FakeBackend([
|
||||
[mock_llm_chunk(content="Response")],
|
||||
[mock_llm_chunk(content="Response after reset")],
|
||||
])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
first_session_id = agent.session_id
|
||||
|
||||
await agent._reset_session()
|
||||
[_ async for _ in agent.act("Hello again")]
|
||||
|
||||
assert len(backend.requests_metadata) >= 2
|
||||
reset_meta = backend.requests_metadata[1]
|
||||
assert reset_meta is not None
|
||||
assert reset_meta["session_id"] == agent.session_id
|
||||
assert reset_meta["parent_session_id"] == first_session_id
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_passes_entrypoint_metadata_to_backend(vibe_config: VibeConfig):
|
||||
metadata = EntrypointMetadata(
|
||||
agent_entrypoint="acp",
|
||||
agent_version="2.0.0",
|
||||
client_name="vibe_ide",
|
||||
client_version="0.5.0",
|
||||
)
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
agent = build_test_agent_loop(
|
||||
config=vibe_config,
|
||||
backend=backend,
|
||||
enable_streaming=True,
|
||||
entrypoint_metadata=metadata,
|
||||
)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_metadata) > 0
|
||||
meta = backend.requests_metadata[0]
|
||||
assert meta is not None
|
||||
assert meta["agent_entrypoint"] == "acp"
|
||||
assert meta["agent_version"] == "2.0.0"
|
||||
assert meta["client_name"] == "vibe_ide"
|
||||
assert meta["client_version"] == "0.5.0"
|
||||
assert meta["session_id"] == agent.session_id
|
||||
assert "message_id" in meta
|
||||
assert meta["call_type"] == "main_call"
|
||||
assert meta["call_source"] == "vibe_code"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_mcp_sampling_handler_uses_updated_backend_when_agent_backend_changes():
|
||||
"""AgentLoop's MCP sampling handler uses current backend when backend is reassigned."""
|
||||
backend1 = FakeBackend([mock_llm_chunk(content="from-backend-1")])
|
||||
backend2 = FakeBackend([mock_llm_chunk(content="from-backend-2")])
|
||||
config = _two_model_vibe_config("devstral-latest")
|
||||
agent = build_test_agent_loop(config=config, backend=backend1)
|
||||
handler = agent._sampling_handler
|
||||
params = _make_sampling_params()
|
||||
context = MagicMock()
|
||||
|
||||
result1 = await handler(context, params)
|
||||
assert isinstance(result1, CreateMessageResult)
|
||||
assert result1.content.type == "text"
|
||||
assert result1.content.text == "from-backend-1"
|
||||
assert len(backend1.requests_messages) == 1
|
||||
assert len(backend2.requests_messages) == 0
|
||||
|
||||
agent.backend = backend2
|
||||
result2 = await handler(context, params)
|
||||
assert isinstance(result2, CreateMessageResult)
|
||||
assert result2.content.type == "text"
|
||||
assert result2.content.text == "from-backend-2"
|
||||
assert len(backend1.requests_messages) == 1
|
||||
assert len(backend2.requests_messages) == 1
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_mcp_sampling_handler_uses_updated_config_when_agent_config_changes():
|
||||
chunk = mock_llm_chunk(content="ok")
|
||||
backend = FakeBackend([chunk])
|
||||
config1 = _two_model_vibe_config("devstral-latest")
|
||||
config2 = _two_model_vibe_config("devstral-small")
|
||||
agent = build_test_agent_loop(config=config1, backend=backend)
|
||||
handler = agent._sampling_handler
|
||||
params = _make_sampling_params()
|
||||
context = MagicMock()
|
||||
|
||||
result1 = await handler(context, params)
|
||||
assert isinstance(result1, CreateMessageResult)
|
||||
assert result1.model == "mistral-vibe-cli-latest"
|
||||
|
||||
agent._base_config = config2
|
||||
agent.agent_manager.invalidate_config()
|
||||
result2 = await handler(context, params)
|
||||
assert isinstance(result2, CreateMessageResult)
|
||||
assert result2.model == "devstral-small-latest"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_mcp_sampling_handler_sends_secondary_call_telemetry_metadata():
|
||||
metadata = EntrypointMetadata(
|
||||
agent_entrypoint="acp",
|
||||
agent_version="2.0.0",
|
||||
client_name="vibe_ide",
|
||||
client_version="0.5.0",
|
||||
)
|
||||
backend = FakeBackend([
|
||||
[mock_llm_chunk(content="Response")],
|
||||
[mock_llm_chunk(content="Sampled response")],
|
||||
])
|
||||
agent = build_test_agent_loop(
|
||||
config=_two_model_vibe_config("devstral-latest"),
|
||||
backend=backend,
|
||||
entrypoint_metadata=metadata,
|
||||
)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
agent.parent_session_id = "parent-session-456"
|
||||
|
||||
result = await agent._sampling_handler(MagicMock(), _make_sampling_params())
|
||||
|
||||
assert isinstance(result, CreateMessageResult)
|
||||
assert len(backend.requests_metadata) == 2
|
||||
sampling_metadata = backend.requests_metadata[1]
|
||||
assert sampling_metadata is not None
|
||||
assert sampling_metadata["agent_entrypoint"] == "acp"
|
||||
assert sampling_metadata["agent_version"] == "2.0.0"
|
||||
assert sampling_metadata["client_name"] == "vibe_ide"
|
||||
assert sampling_metadata["client_version"] == "0.5.0"
|
||||
assert sampling_metadata["session_id"] == agent.session_id
|
||||
assert sampling_metadata["parent_session_id"] == "parent-session-456"
|
||||
assert sampling_metadata["message_id"] == next(
|
||||
message.message_id for message in agent.messages if message.role == Role.user
|
||||
)
|
||||
assert sampling_metadata["call_type"] == "secondary_call"
|
||||
assert sampling_metadata["call_source"] == "vibe_code"
|
||||
|
||||
assert len(backend.requests_extra_headers) == 2
|
||||
sampling_headers = backend.requests_extra_headers[1]
|
||||
assert sampling_headers is not None
|
||||
assert sampling_headers["x-affinity"] == agent.session_id
|
||||
|
||||
|
||||
def _generic_provider_vibe_config() -> VibeConfig:
|
||||
"""VibeConfig with generic backend so no metadata header is sent."""
|
||||
providers = [
|
||||
ProviderConfig(
|
||||
name="mistral",
|
||||
api_base="https://api.mistral.ai/v1",
|
||||
api_key_env_var="MISTRAL_API_KEY",
|
||||
backend=Backend.GENERIC,
|
||||
)
|
||||
]
|
||||
return build_test_vibe_config(providers=providers)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_mistral_metadata_header_call_type_per_turn() -> None:
|
||||
"""First LLM call in a turn is main_call; second call (after tools) is secondary_call."""
|
||||
tool_call = ToolCall(
|
||||
id="call_1",
|
||||
index=0,
|
||||
function=FunctionCall(name="todo", arguments='{"action": "read"}'),
|
||||
)
|
||||
backend = FakeBackend([
|
||||
[mock_llm_chunk(content="Checking todos.", tool_calls=[tool_call])],
|
||||
[mock_llm_chunk(content="Here are your todos.")],
|
||||
])
|
||||
config = build_test_vibe_config(
|
||||
providers=[
|
||||
ProviderConfig(
|
||||
name="mistral",
|
||||
api_base="https://api.mistral.ai/v1",
|
||||
api_key_env_var="MISTRAL_API_KEY",
|
||||
backend=Backend.MISTRAL,
|
||||
)
|
||||
],
|
||||
enabled_tools=["todo"],
|
||||
tools={"todo": BaseToolConfig(permission=ToolPermission.ALWAYS)},
|
||||
)
|
||||
agent = build_test_agent_loop(
|
||||
config=config, backend=backend, agent_name=BuiltinAgentName.AUTO_APPROVE
|
||||
)
|
||||
|
||||
[_ async for _ in agent.act("What's on my todo list?")]
|
||||
|
||||
assert len(backend.requests_metadata) == 2
|
||||
first_metadata = backend.requests_metadata[0]
|
||||
second_metadata = backend.requests_metadata[1]
|
||||
assert first_metadata is not None
|
||||
assert second_metadata is not None
|
||||
assert first_metadata["call_type"] == "main_call"
|
||||
assert second_metadata["call_type"] == "secondary_call"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_auto_compact_emits_summary_and_next_turn_metadata() -> None:
|
||||
"""Compact emits summary then user-turn backend metadata in order."""
|
||||
backend = FakeBackend([
|
||||
[mock_llm_chunk(content="<summary>")],
|
||||
[mock_llm_chunk(content="<final>")],
|
||||
])
|
||||
config = build_test_vibe_config(
|
||||
models=make_test_models(auto_compact_threshold=1),
|
||||
providers=[
|
||||
ProviderConfig(
|
||||
name="mistral",
|
||||
api_base="https://api.mistral.ai/v1",
|
||||
api_key_env_var="MISTRAL_API_KEY",
|
||||
backend=Backend.MISTRAL,
|
||||
)
|
||||
],
|
||||
)
|
||||
agent = build_test_agent_loop(config=config, backend=backend)
|
||||
agent.stats.context_tokens = 2
|
||||
original_session_id = agent.session_id
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_metadata) == 2
|
||||
assert len(backend.requests_extra_headers) == 2
|
||||
compact_metadata = backend.requests_metadata[0]
|
||||
user_turn_metadata = backend.requests_metadata[1]
|
||||
assert compact_metadata is not None
|
||||
assert user_turn_metadata is not None
|
||||
assert compact_metadata["call_type"] == "secondary_call"
|
||||
assert compact_metadata["session_id"] == original_session_id
|
||||
assert "parent_session_id" not in compact_metadata
|
||||
assert user_turn_metadata["call_type"] == "main_call"
|
||||
assert user_turn_metadata["session_id"] == agent.session_id
|
||||
assert user_turn_metadata["parent_session_id"] == original_session_id
|
||||
|
||||
compact_headers = backend.requests_extra_headers[0]
|
||||
user_turn_headers = backend.requests_extra_headers[1]
|
||||
assert compact_headers is not None
|
||||
assert user_turn_headers is not None
|
||||
assert compact_headers["x-affinity"] == original_session_id
|
||||
assert user_turn_headers["x-affinity"] == agent.session_id
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_generic_provider_has_no_metadata_header() -> None:
|
||||
"""Non-Mistral provider does not send the metadata header."""
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
config = _generic_provider_vibe_config()
|
||||
agent = build_test_agent_loop(config=config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_extra_headers) == 1
|
||||
headers = backend.requests_extra_headers[0]
|
||||
assert headers is not None
|
||||
assert "metadata" not in headers
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_provider_extra_headers_are_forwarded() -> None:
|
||||
backend = FakeBackend([mock_llm_chunk(content="Response")])
|
||||
providers = [
|
||||
ProviderConfig(
|
||||
name="custom",
|
||||
api_base="https://custom.example.com/v1",
|
||||
extra_headers={"X-Custom-Auth": "token123", "X-Org-Id": "org-456"},
|
||||
)
|
||||
]
|
||||
models = [ModelConfig(name="test-model", provider="custom", alias="test")]
|
||||
config = build_test_vibe_config(
|
||||
active_model="test", models=models, providers=providers
|
||||
)
|
||||
agent = build_test_agent_loop(config=config, backend=backend)
|
||||
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
assert len(backend.requests_extra_headers) == 1
|
||||
headers = backend.requests_extra_headers[0]
|
||||
assert headers is not None
|
||||
assert headers["X-Custom-Auth"] == "token123"
|
||||
assert headers["X-Org-Id"] == "org-456"
|
||||
|
||||
|
||||
def _refusal_chunk() -> LLMChunk:
|
||||
return LLMChunk(
|
||||
message=LLMMessage(role=Role.assistant, content=""),
|
||||
usage=LLMUsage(prompt_tokens=10, completion_tokens=2),
|
||||
stop=StopInfo(reason="refusal"),
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_refusal_stop_reason_raises_refusal_error(vibe_config: VibeConfig):
|
||||
backend = FakeBackend([_refusal_chunk()])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
with pytest.raises(RefusalError):
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_refusal_stop_reason_raises_refusal_error_streaming(
|
||||
vibe_config: VibeConfig,
|
||||
):
|
||||
backend = FakeBackend([_refusal_chunk()])
|
||||
agent = build_test_agent_loop(
|
||||
config=vibe_config, backend=backend, enable_streaming=True
|
||||
)
|
||||
|
||||
with pytest.raises(RefusalError):
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
|
||||
def _refusal_chunk_with_details() -> LLMChunk:
|
||||
return LLMChunk(
|
||||
message=LLMMessage(role=Role.assistant, content=""),
|
||||
usage=LLMUsage(prompt_tokens=10, completion_tokens=2),
|
||||
stop=StopInfo(
|
||||
reason="refusal",
|
||||
category="cyber",
|
||||
explanation="This request was declined for safety reasons.",
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_refusal_error_carries_category_and_explanation(vibe_config: VibeConfig):
|
||||
backend = FakeBackend([_refusal_chunk_with_details()])
|
||||
agent = build_test_agent_loop(config=vibe_config, backend=backend)
|
||||
|
||||
with pytest.raises(RefusalError) as exc_info:
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
err = exc_info.value
|
||||
assert err.category == "cyber"
|
||||
assert err.explanation == "This request was declined for safety reasons."
|
||||
assert "This request was declined for safety reasons." in str(err)
|
||||
assert "cyber" in str(err)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_refusal_error_carries_category_and_explanation_streaming(
|
||||
vibe_config: VibeConfig,
|
||||
):
|
||||
backend = FakeBackend([_refusal_chunk_with_details()])
|
||||
agent = build_test_agent_loop(
|
||||
config=vibe_config, backend=backend, enable_streaming=True
|
||||
)
|
||||
|
||||
with pytest.raises(RefusalError) as exc_info:
|
||||
[_ async for _ in agent.act("Hello")]
|
||||
|
||||
err = exc_info.value
|
||||
assert err.category == "cyber"
|
||||
assert err.explanation == "This request was declined for safety reasons."
|
||||
assert "This request was declined for safety reasons." in str(err)
|
||||
assert "cyber" in str(err)
|
||||
Loading…
Add table
Add a link
Reference in a new issue