v2.14.1 (#756)
Co-authored-by: Clément Drouin <clement.drouin@mistral.ai> Co-authored-by: Gauthier Guinet <43207538+Gguinet@users.noreply.github.com> Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com> Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai> Co-authored-by: Stanislas <stanislas.lange@mistral.ai> Co-authored-by: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
Mathias Gesbert
GitHub
parent
3f8487f761
commit
702d0f412e
51 changed files with 2446 additions and 502 deletions
224
tests/cli/test_startup_update_prompt.py
Normal file
224
tests/cli/test_startup_update_prompt.py
Normal file
|
|
@ -0,0 +1,224 @@
|
|||
from __future__ import annotations
|
||||
|
||||
import asyncio
|
||||
from pathlib import Path
|
||||
import time
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
from tests.conftest import build_test_vibe_config
|
||||
from vibe.cli.cli import _maybe_run_startup_update_prompt
|
||||
from vibe.cli.update_notifier import FileSystemUpdateCacheRepository, UpdateCache
|
||||
from vibe.setup.update_prompt.update_prompt_dialog import UpdatePromptResult
|
||||
|
||||
|
||||
class _BrokenRepository:
|
||||
async def get(self) -> UpdateCache | None:
|
||||
raise OSError("disk on fire")
|
||||
|
||||
async def set(self, update_cache: UpdateCache) -> None:
|
||||
raise OSError("disk on fire")
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def repository(tmp_path: Path) -> FileSystemUpdateCacheRepository:
|
||||
return FileSystemUpdateCacheRepository(base_path=tmp_path)
|
||||
|
||||
|
||||
def _write_pending_update(
|
||||
repository: FileSystemUpdateCacheRepository, version: str
|
||||
) -> None:
|
||||
asyncio.run(
|
||||
repository.set(
|
||||
UpdateCache(latest_version=version, stored_at_timestamp=int(time.time()))
|
||||
)
|
||||
)
|
||||
|
||||
|
||||
def test_no_op_when_update_checks_are_disabled(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=False)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with patch("vibe.cli.cli.ask_update_prompt") as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
mock_ask.assert_not_called()
|
||||
|
||||
|
||||
def test_no_op_when_no_pending_update_is_cached(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
|
||||
with patch("vibe.cli.cli.ask_update_prompt") as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
mock_ask.assert_not_called()
|
||||
|
||||
|
||||
def test_prompt_is_shown_and_continue_returns_without_exiting(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.CONTINUE
|
||||
) as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
mock_ask.assert_called_once()
|
||||
|
||||
|
||||
def test_quit_exits_zero(repository: FileSystemUpdateCacheRepository) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch("vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.QUIT),
|
||||
pytest.raises(SystemExit) as excinfo,
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert excinfo.value.code == 0
|
||||
|
||||
|
||||
def test_successful_update_exits_zero(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.UPDATED
|
||||
),
|
||||
pytest.raises(SystemExit) as excinfo,
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert excinfo.value.code == 0
|
||||
|
||||
|
||||
def test_failed_update_exits_one(repository: FileSystemUpdateCacheRepository) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch(
|
||||
"vibe.cli.cli.ask_update_prompt",
|
||||
return_value=UpdatePromptResult.UPDATE_FAILED,
|
||||
),
|
||||
pytest.raises(SystemExit) as excinfo,
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert excinfo.value.code == 1
|
||||
|
||||
|
||||
def test_no_op_when_cache_read_raises_oserror() -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
repository = _BrokenRepository()
|
||||
|
||||
with patch("vibe.cli.cli.ask_update_prompt") as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
mock_ask.assert_not_called()
|
||||
|
||||
|
||||
def test_continue_marks_version_as_dismissed_and_prevents_reprompt(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.CONTINUE
|
||||
) as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert mock_ask.call_count == 1
|
||||
|
||||
|
||||
def test_continue_reprompts_when_a_newer_version_appears(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.CONTINUE
|
||||
) as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
_write_pending_update(repository, "1000.0.0")
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert mock_ask.call_count == 2
|
||||
|
||||
|
||||
def test_successful_update_prints_restart_hint(
|
||||
repository: FileSystemUpdateCacheRepository, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.UPDATED
|
||||
),
|
||||
pytest.raises(SystemExit),
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
out = capsys.readouterr().out
|
||||
assert "999.0.0" in out
|
||||
assert "Run" in out and "vibe" in out
|
||||
|
||||
|
||||
def test_failed_update_prints_error_message(
|
||||
repository: FileSystemUpdateCacheRepository, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch(
|
||||
"vibe.cli.cli.ask_update_prompt",
|
||||
return_value=UpdatePromptResult.UPDATE_FAILED,
|
||||
),
|
||||
pytest.raises(SystemExit),
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
assert "could not be updated automatically" in capsys.readouterr().out
|
||||
|
||||
|
||||
def test_failed_update_does_not_dismiss_so_user_is_reprompted_on_next_launch(
|
||||
repository: FileSystemUpdateCacheRepository,
|
||||
) -> None:
|
||||
config = build_test_vibe_config(enable_update_checks=True)
|
||||
_write_pending_update(repository, "999.0.0")
|
||||
|
||||
with (
|
||||
patch(
|
||||
"vibe.cli.cli.ask_update_prompt",
|
||||
return_value=UpdatePromptResult.UPDATE_FAILED,
|
||||
),
|
||||
pytest.raises(SystemExit),
|
||||
):
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
cache = asyncio.run(repository.get())
|
||||
assert cache is not None
|
||||
assert cache.dismissed_version is None
|
||||
|
||||
with patch(
|
||||
"vibe.cli.cli.ask_update_prompt", return_value=UpdatePromptResult.CONTINUE
|
||||
) as mock_ask:
|
||||
_maybe_run_startup_update_prompt(config, repository)
|
||||
|
||||
mock_ask.assert_called_once()
|
||||
Loading…
Add table
Add a link
Reference in a new issue