v2.14.1 (#756)

Co-authored-by: Clément Drouin <clement.drouin@mistral.ai>
Co-authored-by: Gauthier Guinet <43207538+Gguinet@users.noreply.github.com>
Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com>
Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai>
Co-authored-by: Stanislas <stanislas.lange@mistral.ai>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/core/test_build_attachment_counts.py

@@ -0,0 +1,34 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+from vibe.core.telemetry.build_metadata import build_attachment_counts
+from vibe.core.telemetry.types import AttachmentKind
+from vibe.core.types import ImageAttachment, LLMMessage, Role
+
+
+def _msg(images: list[ImageAttachment] | None) -> LLMMessage:
+    return LLMMessage(role=Role.user, content="hi", images=images)
+
+
+def _image() -> ImageAttachment:
+    return ImageAttachment(
+        path=Path("/tmp/x.png"), alias="x.png", mime_type="image/png"
+    )
+
+
+def test_returns_empty_when_message_is_none() -> None:
+    assert build_attachment_counts(None, supports_images=True) == {}
+
+
+def test_returns_empty_when_no_images() -> None:
+    assert build_attachment_counts(_msg(None), supports_images=True) == {}
+
+
+def test_counts_images_when_model_supports_them() -> None:
+    counts = build_attachment_counts(_msg([_image(), _image()]), supports_images=True)
+    assert counts == {AttachmentKind.IMAGE: 2}
+
+
+def test_drops_images_when_model_does_not_support_them() -> None:
+    assert build_attachment_counts(_msg([_image()]), supports_images=False) == {}

tests/core/test_telemetry_send.py

@@ -15,7 +15,11 @@ from vibe.core.telemetry.build_metadata import (
     build_request_metadata,
 )
 from vibe.core.telemetry.send import TelemetryClient
-from vibe.core.telemetry.types import EntrypointMetadata, TelemetryRequestMetadata
+from vibe.core.telemetry.types import (
+    AttachmentKind,
+    EntrypointMetadata,
+    TelemetryRequestMetadata,
+)
 from vibe.core.tools.base import BaseTool, ToolPermission
 from vibe.core.types import Backend
 from vibe.core.utils import get_user_agent
@@ -694,6 +698,43 @@ class TestTelemetryClient:
         assert properties["call_source"] == "vibe_code"
         assert properties["call_type"] == "main_call"
         assert properties["message_id"] is None
+        assert properties["attachment_counts"] == {}
+
+    def test_send_request_sent_payload_with_attachments(
+        self, telemetry_events: list[dict[str, Any]]
+    ) -> None:
+        config = build_test_vibe_config(enable_telemetry=True)
+        client = TelemetryClient(config_getter=lambda: config)
+
+        client.send_request_sent(
+            model="codestral",
+            nb_context_chars=1234,
+            nb_context_messages=5,
+            nb_prompt_chars=42,
+            call_type="main_call",
+            attachment_counts={AttachmentKind.IMAGE: 2},
+        )
+
+        assert len(telemetry_events) == 1
+        properties = telemetry_events[0]["properties"]
+        assert properties["attachment_counts"] == {"image": 2}
+
+    def test_send_request_sent_payload_drops_zero_counts(
+        self, telemetry_events: list[dict[str, Any]]
+    ) -> None:
+        config = build_test_vibe_config(enable_telemetry=True)
+        client = TelemetryClient(config_getter=lambda: config)
+
+        client.send_request_sent(
+            model="codestral",
+            nb_context_chars=1234,
+            nb_context_messages=5,
+            nb_prompt_chars=42,
+            call_type="main_call",
+            attachment_counts={AttachmentKind.IMAGE: 0},
+        )
+
+        assert telemetry_events[0]["properties"]["attachment_counts"] == {}
 
     def test_send_user_rating_feedback_payload(
         self, telemetry_events: list[dict[str, Any]]