v2.18.4 (#866)

Co-authored-by: Albert Jiang <aj@mistral.ai>
Co-authored-by: Clément Drouin <clement.drouin@mistral.ai>
Co-authored-by: Laure Hugo <201583486+laure0303@users.noreply.github.com>
Co-authored-by: Mathias Gesbert <mathias.gesbert@mistral.ai>
Co-authored-by: Mert Unsal <mert.unsal@mistral.ai>
Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com>
Co-authored-by: Paul VEZIA <166131032+le-codeur-rapide@users.noreply.github.com>
Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai>
Co-authored-by: Quentin <quentin.torroba@mistral.ai>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/acp/test_initialize.py

@@ -72,7 +72,7 @@ class TestACPInitialize:
             ),
         )
         assert response.agent_info == Implementation(
-            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.18.3"
+            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.18.4"
         )
 
         assert response.auth_methods is not None
@@ -172,7 +172,7 @@ class TestACPInitialize:
             ),
         )
         assert response.agent_info == Implementation(
-            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.18.3"
+            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.18.4"
         )
 
         assert response.auth_methods is not None

tests/acp/test_load_session.py

@@ -62,6 +62,53 @@ def acp_agent_with_session_config(
     return vibe_acp_agent, client
 
 
+@pytest.mark.asyncio
+async def test_load_session_honors_default_agent(
+    backend: FakeBackend,
+    temp_session_dir: Path,
+    create_test_session,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    session_config = SessionLoggingConfig(
+        save_dir=str(temp_session_dir), session_prefix="session", enabled=True
+    )
+    config = build_test_vibe_config(
+        default_agent=BuiltinAgentName.PLAN,
+        models=[
+            ModelConfig(
+                name="devstral-latest", provider="mistral", alias="devstral-latest"
+            )
+        ],
+        session_logging=session_config,
+    )
+
+    class PatchedAgentLoop(AgentLoop):
+        def __init__(self, *args, **kwargs) -> None:
+            super().__init__(*args, **{**kwargs, "backend": backend})
+            self._base_config = config
+            self.agent_manager.invalidate_config()
+
+    monkeypatch.setattr("vibe.acp.acp_agent_loop.AgentLoop", PatchedAgentLoop)
+    monkeypatch.setattr(VibeAcpAgentLoop, "_load_config", lambda self: config)
+
+    vibe_acp_agent = VibeAcpAgentLoop()
+    client = FakeClient()
+    vibe_acp_agent.on_connect(client)
+    client.on_connect(vibe_acp_agent)
+
+    session_id = "test-sess-12345678"
+    cwd = str(Path.cwd())
+    create_test_session(temp_session_dir, session_id, cwd)
+
+    response = await vibe_acp_agent.load_session(
+        cwd=cwd, mcp_servers=[], session_id=session_id
+    )
+
+    assert response is not None
+    assert response.modes is not None
+    assert response.modes.current_mode_id == BuiltinAgentName.PLAN
+
+
 class TestLoadSession:
     @pytest.mark.asyncio
     async def test_load_session_response_structure(

tests/acp/test_new_session.py

@@ -365,3 +365,35 @@ class TestACPNewSession:
 
         assert session_response.models is not None
         assert session_response.models.current_model_id == "devstral-small"
+
+
+@pytest.mark.asyncio
+async def test_new_session_honors_default_agent(
+    backend, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    config = build_test_vibe_config(
+        default_agent=BuiltinAgentName.PLAN,
+        models=[
+            ModelConfig(
+                name="devstral-latest", provider="mistral", alias="devstral-latest"
+            )
+        ],
+    )
+
+    class PatchedAgentLoop(AgentLoop):
+        def __init__(self, *args, **kwargs) -> None:
+            super().__init__(*args, **{**kwargs, "backend": backend})
+            self._base_config = config
+            self.agent_manager.invalidate_config()
+
+    monkeypatch.setattr("vibe.acp.acp_agent_loop.AgentLoop", PatchedAgentLoop)
+    monkeypatch.setattr(VibeAcpAgentLoop, "_load_config", lambda self: config)
+
+    acp_agent_loop = _create_acp_agent()
+
+    session_response = await acp_agent_loop.new_session(
+        cwd=str(Path.cwd()), mcp_servers=[]
+    )
+
+    assert session_response.modes is not None
+    assert session_response.modes.current_mode_id == BuiltinAgentName.PLAN