v2.4.0 (#470)

Co-authored-by: Quentin Torroba <quentin.torroba@mistral.ai>
Co-authored-by: Kim-Adeline Miguel <kimadeline.miguel@mistral.ai>
Co-authored-by: Vincent Guilloux <vincent.guilloux@mistral.ai>
Co-authored-by: Clement Sirieix <clem.sirieix@gmail.com>
Co-authored-by: Antoine W <antoine.wronka@mistral.ai>
Co-authored-by: Mistral Vibe <vibe@mistral.ai>

tests/acp/test_compact_session_updates.py

@@ -7,7 +7,7 @@ from unittest.mock import patch
 from acp.schema import TextContentBlock, ToolCallProgress, ToolCallStart
 import pytest
 
-from tests.conftest import build_test_vibe_config
+from tests.conftest import build_test_vibe_config, make_test_models
 from tests.stubs.fake_backend import FakeBackend
 from tests.stubs.fake_client import FakeClient
 from vibe.acp.acp_agent_loop import VibeAcpAgentLoop
@@ -18,8 +18,9 @@ from vibe.core.agent_loop import AgentLoop
 def acp_agent_loop(backend: FakeBackend) -> VibeAcpAgentLoop:
     class PatchedAgent(AgentLoop):
         def __init__(self, *args, **kwargs) -> None:
-            # Force our config with auto_compact_threshold=1
-            kwargs["config"] = build_test_vibe_config(auto_compact_threshold=1)
+            kwargs["config"] = build_test_vibe_config(
+                models=make_test_models(auto_compact_threshold=1)
+            )
             super().__init__(*args, **kwargs, backend=backend)
 
     patch("vibe.acp.acp_agent_loop.AgentLoop", side_effect=PatchedAgent).start()

tests/acp/test_initialize.py

@@ -28,7 +28,7 @@ class TestACPInitialize:
             session_capabilities=SessionCapabilities(list=SessionListCapabilities()),
         )
         assert response.agent_info == Implementation(
-            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.3.0"
+            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.4.0"
         )
 
         assert response.auth_methods == []
@@ -52,7 +52,7 @@ class TestACPInitialize:
             session_capabilities=SessionCapabilities(list=SessionListCapabilities()),
         )
         assert response.agent_info == Implementation(
-            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.3.0"
+            name="@mistralai/mistral-vibe", title="Mistral Vibe", version="2.4.0"
         )
 
         assert response.auth_methods is not None

tests/acp/test_search_replace.py

@@ -114,6 +114,10 @@ class TestAcpSearchReplaceExecution:
         assert isinstance(result, SearchReplaceResult)
         assert result.file == str(test_file)
         assert result.blocks_applied == 1
+        assert (
+            result.file_content_before
+            == "original line 1\noriginal line 2\noriginal line 3"
+        )
         assert mock_client._read_text_file_called
         assert mock_client._write_text_file_called
         assert mock_client._session_update_called
@@ -314,6 +318,7 @@ class TestAcpSearchReplaceSessionUpdates:
             lines_changed=1,
             content=search_replace_content,
             warnings=[],
+            file_content_before="old text",
         )
 
         event = ToolResultEvent(

tests/acp/test_set_config_option.py

@@ -106,6 +106,36 @@ class TestACPSetConfigOptionMode:
         assert response is not None
         assert acp_session.agent_loop.agent_profile.name == BuiltinAgentName.PLAN
 
+    @pytest.mark.asyncio
+    async def test_set_config_option_mode_to_chat(
+        self, acp_agent_loop: VibeAcpAgentLoop
+    ) -> None:
+        session_response = await acp_agent_loop.new_session(
+            cwd=str(Path.cwd()), mcp_servers=[]
+        )
+        session_id = session_response.session_id
+        acp_session = next(
+            (s for s in acp_agent_loop.sessions.values() if s.id == session_id), None
+        )
+        assert acp_session is not None
+        assert acp_session.agent_loop.agent_profile.name == BuiltinAgentName.DEFAULT
+
+        response = await acp_agent_loop.set_config_option(
+            session_id=session_id, config_id="mode", value=BuiltinAgentName.CHAT
+        )
+
+        assert response is not None
+        assert response.config_options is not None
+        assert len(response.config_options) == 2
+        assert acp_session.agent_loop.agent_profile.name == BuiltinAgentName.CHAT
+        assert (
+            acp_session.agent_loop.auto_approve is True
+        )  # Chat mode auto-approves read-only tools
+
+        mode_config = response.config_options[0]
+        assert mode_config.root.id == "mode"
+        assert mode_config.root.current_value == BuiltinAgentName.CHAT
+
     @pytest.mark.asyncio
     async def test_set_config_option_mode_invalid_returns_none(
         self, acp_agent_loop: VibeAcpAgentLoop

tests/acp/test_set_mode.py

@@ -76,8 +76,8 @@ class TestACPSetMode:
         assert response is not None
         assert acp_session.agent_loop.agent_profile.name == BuiltinAgentName.PLAN
         assert (
-            acp_session.agent_loop.auto_approve is True
-        )  # Plan mode auto-approves read-only tools
+            acp_session.agent_loop.auto_approve is False
+        )  # Plan mode uses per-tool allowlists, not global auto-approve
 
     @pytest.mark.asyncio
     async def test_set_mode_to_accept_edits(

tests/acp/test_write_file.py

@@ -80,6 +80,7 @@ class TestAcpWriteFileExecution:
         assert result.content == "Hello, world!"
         assert result.bytes_written == len(b"Hello, world!")
         assert result.file_existed is False
+        assert result.file_content_before is None
         assert mock_client._write_text_file_called
         assert mock_client._session_update_called
 
@@ -113,6 +114,7 @@ class TestAcpWriteFileExecution:
         assert result.content == "New content"
         assert result.bytes_written == len(b"New content")
         assert result.file_existed is True
+        assert result.file_content_before == ""
         assert mock_client._write_text_file_called
         assert mock_client._session_update_called