702d0f412e
Co-authored-by: Clément Drouin <clement.drouin@mistral.ai> Co-authored-by: Gauthier Guinet <43207538+Gguinet@users.noreply.github.com> Co-authored-by: Michel Thomazo <51709227+michelTho@users.noreply.github.com> Co-authored-by: Pierre Rossinès <pierre.rossines@mistral.ai> Co-authored-by: Stanislas <stanislas.lange@mistral.ai> Co-authored-by: Mistral Vibe <vibe@mistral.ai>
440 lines
14 KiB
Python
440 lines
14 KiB
Python
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from tests.update_notifier.adapters.fake_update_cache_repository import (
|
|
FakeUpdateCacheRepository,
|
|
)
|
|
from tests.update_notifier.adapters.fake_update_gateway import FakeUpdateGateway
|
|
from vibe.cli.update_notifier import (
|
|
Update,
|
|
UpdateCache,
|
|
UpdateGatewayCause,
|
|
UpdateGatewayError,
|
|
)
|
|
from vibe.cli.update_notifier.update import (
|
|
UpdateError,
|
|
get_pending_update_from_cache,
|
|
get_update_if_available,
|
|
mark_update_as_dismissed,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def current_timestamp() -> int:
|
|
return 1765278683
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_the_latest_update_when_available() -> None:
|
|
latest_update = "1.0.3"
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version=latest_update))
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is not None
|
|
assert update.latest_version == latest_update
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_the_current_version_is_the_latest() -> None:
|
|
current_version = "1.0.0"
|
|
latest_version = "1.0.0"
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version=latest_version))
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version=current_version,
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_the_current_version_is_greater_than_the_latest() -> (
|
|
None
|
|
):
|
|
current_version = "0.2.0"
|
|
latest_version = "0.1.2"
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version=latest_version))
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version=current_version,
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_no_version_is_available() -> None:
|
|
update_notifier = FakeUpdateGateway(update=None)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_latest_version_is_invalid() -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="invalid-version"))
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_replaces_hyphens_with_plus_signs_in_latest_version_to_conform_with_PEP_440() -> (
|
|
None
|
|
):
|
|
update_notifier = FakeUpdateGateway(
|
|
# if we were not replacing hyphens with plus signs, this should fail for PEP 440
|
|
update=Update(latest_version="1.6.1-jetbrains")
|
|
)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is not None
|
|
assert update.latest_version == "1.6.1-jetbrains"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_current_version_is_invalid() -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.1"))
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="invalid-version",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert update is None
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("cause", "expected_message_substring"),
|
|
[
|
|
(UpdateGatewayCause.TOO_MANY_REQUESTS, "Rate limit exceeded"),
|
|
(UpdateGatewayCause.INVALID_RESPONSE, "invalid response"),
|
|
(
|
|
UpdateGatewayCause.NOT_FOUND,
|
|
"Unable to fetch the releases. Please check your permissions.",
|
|
),
|
|
(UpdateGatewayCause.ERROR_RESPONSE, "Unexpected response"),
|
|
(UpdateGatewayCause.REQUEST_FAILED, "Network error"),
|
|
],
|
|
)
|
|
@pytest.mark.asyncio
|
|
async def test_raises_update_error(
|
|
cause: UpdateGatewayCause, expected_message_substring: str
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(error=UpdateGatewayError(cause=cause))
|
|
|
|
with pytest.raises(UpdateError) as excinfo:
|
|
await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=FakeUpdateCacheRepository(),
|
|
)
|
|
|
|
assert expected_message_substring in str(excinfo.value)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_notifies_and_updates_cache_when_repository_is_empty(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.1"))
|
|
update_cache_repository = FakeUpdateCacheRepository()
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update is not None
|
|
assert update.latest_version == "1.0.1"
|
|
assert update.should_notify is True
|
|
assert update_notifier.fetch_update_calls == 1
|
|
assert update_cache_repository.update_cache is not None
|
|
assert update_cache_repository.update_cache.latest_version == "1.0.1"
|
|
assert update_cache_repository.update_cache.stored_at_timestamp == current_timestamp
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_does_not_notify_when_an_available_update_has_been_recently_cached(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.1"))
|
|
timestamp_twelve_hours_ago = current_timestamp - 12 * 60 * 60
|
|
update_cache = UpdateCache(
|
|
latest_version="1.0.1", stored_at_timestamp=timestamp_twelve_hours_ago
|
|
)
|
|
update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update is not None
|
|
assert update.latest_version == "1.0.1"
|
|
assert update.should_notify is False
|
|
assert update_notifier.fetch_update_calls == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_nothing_when_the_recently_cached_update_is_the_one_currently_in_use(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.1"))
|
|
timestamp_twelve_hours_ago = current_timestamp - 12 * 60 * 60
|
|
update_cache = UpdateCache(
|
|
latest_version="1.0.1", stored_at_timestamp=timestamp_twelve_hours_ago
|
|
)
|
|
update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.1",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update is None
|
|
assert update_notifier.fetch_update_calls == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_retrieves_fresh_update_and_notifies_and_updates_cache_when_cache_is_not_fresh(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.2"))
|
|
timestamp_two_days_ago = current_timestamp - 48 * 60 * 60
|
|
update_cache = UpdateCache(
|
|
latest_version="1.0.1", stored_at_timestamp=timestamp_two_days_ago
|
|
)
|
|
update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update is not None
|
|
assert update_notifier.fetch_update_calls == 1
|
|
assert update.should_notify is True
|
|
assert update.latest_version == "1.0.2"
|
|
assert update_cache_repository.update_cache is not None
|
|
assert update_cache_repository.update_cache.stored_at_timestamp == current_timestamp
|
|
assert update_cache_repository.update_cache.latest_version == "1.0.2"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_updates_cache_timestamp_with_current_version_when_no_update_is_available(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=None)
|
|
timestamp_two_days_ago = current_timestamp - 48 * 60 * 60
|
|
update_cache = UpdateCache(
|
|
latest_version="1.0.0", stored_at_timestamp=timestamp_two_days_ago
|
|
)
|
|
update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
|
|
|
|
update = await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update is None
|
|
assert update_notifier.fetch_update_calls == 1
|
|
assert update_cache_repository.update_cache is not None
|
|
assert update_cache_repository.update_cache.latest_version == "1.0.0"
|
|
assert update_cache_repository.update_cache.stored_at_timestamp == current_timestamp
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_updates_cache_timestamp_with_current_version_when_gateway_errors(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(
|
|
error=UpdateGatewayError(cause=UpdateGatewayCause.ERROR_RESPONSE)
|
|
)
|
|
timestamp_two_days_ago = current_timestamp - 48 * 60 * 60
|
|
update_cache = UpdateCache(
|
|
latest_version="1.0.0", stored_at_timestamp=timestamp_two_days_ago
|
|
)
|
|
update_cache_repository = FakeUpdateCacheRepository(update_cache=update_cache)
|
|
|
|
with pytest.raises(UpdateError):
|
|
await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update_notifier.fetch_update_calls == 1
|
|
assert update_cache_repository.update_cache is not None
|
|
assert update_cache_repository.update_cache.latest_version == "1.0.0"
|
|
assert update_cache_repository.update_cache.stored_at_timestamp == current_timestamp
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_none_when_cache_is_empty() -> None:
|
|
repository = FakeUpdateCacheRepository()
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_none_when_cached_version_equals_current() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(latest_version="1.0.0", stored_at_timestamp=0)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_none_when_cached_version_is_older() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(latest_version="0.9.0", stored_at_timestamp=0)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_version_when_newer_exists() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(latest_version="1.2.3", stored_at_timestamp=0)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") == "1.2.3"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_none_when_current_is_invalid() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(latest_version="1.2.3", stored_at_timestamp=0)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "not-a-version") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_none_when_dismissed() -> None:
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(
|
|
latest_version="1.2.3", stored_at_timestamp=0, dismissed_version="1.2.3"
|
|
)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pending_update_from_cache_returns_version_when_dismissed_is_older() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(
|
|
latest_version="1.3.0", stored_at_timestamp=0, dismissed_version="1.2.3"
|
|
)
|
|
)
|
|
|
|
assert await get_pending_update_from_cache(repository, "1.0.0") == "1.3.0"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mark_update_as_dismissed_persists_version_and_preserves_other_fields() -> (
|
|
None
|
|
):
|
|
repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(
|
|
latest_version="1.2.3",
|
|
stored_at_timestamp=42,
|
|
seen_whats_new_version="1.0.0",
|
|
)
|
|
)
|
|
|
|
await mark_update_as_dismissed(repository, "1.2.3")
|
|
|
|
assert repository.update_cache is not None
|
|
assert repository.update_cache.latest_version == "1.2.3"
|
|
assert repository.update_cache.stored_at_timestamp == 42
|
|
assert repository.update_cache.seen_whats_new_version == "1.0.0"
|
|
assert repository.update_cache.dismissed_version == "1.2.3"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mark_update_as_dismissed_is_a_noop_when_cache_is_empty() -> None:
|
|
repository = FakeUpdateCacheRepository()
|
|
|
|
await mark_update_as_dismissed(repository, "1.2.3")
|
|
|
|
assert repository.update_cache is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_writing_cache_preserves_seen_whats_new_and_dismissed_version(
|
|
current_timestamp: int,
|
|
) -> None:
|
|
update_notifier = FakeUpdateGateway(update=Update(latest_version="1.0.2"))
|
|
timestamp_two_days_ago = current_timestamp - 48 * 60 * 60
|
|
update_cache_repository = FakeUpdateCacheRepository(
|
|
update_cache=UpdateCache(
|
|
latest_version="1.0.1",
|
|
stored_at_timestamp=timestamp_two_days_ago,
|
|
seen_whats_new_version="1.0.0",
|
|
dismissed_version="1.0.1",
|
|
)
|
|
)
|
|
|
|
await get_update_if_available(
|
|
update_notifier,
|
|
current_version="1.0.0",
|
|
update_cache_repository=update_cache_repository,
|
|
get_current_timestamp=lambda: current_timestamp,
|
|
)
|
|
|
|
assert update_cache_repository.update_cache is not None
|
|
assert update_cache_repository.update_cache.latest_version == "1.0.2"
|
|
assert update_cache_repository.update_cache.seen_whats_new_version == "1.0.0"
|
|
assert update_cache_repository.update_cache.dismissed_version == "1.0.1"
|